Add supported CPython/PyPy versions to cargo package metadata #4756
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
cpython-pypy-version-support-metadata
branch
from
7a38b06 to
1aaca98
Compare
davidhewitt
reviewed
Dec 3, 2024
messense
force-pushed
the
cpython-pypy-version-support-metadata
branch
from
1aaca98 to
a2d6030
Compare
|
Test added. |
messense
force-pushed
the
cpython-pypy-version-support-metadata
branch
from
a2d6030 to
0bc5125
Compare
davidhewitt
reviewed
Feb 27, 2025
There was a problem hiding this comment.
I wonder, can we generate PY_VERSIONS and PYPY_VERSIONS in this file from the metadata?
| @@ -44,6 +44,8 @@ def test(session: nox.Session) -> None: | |||
|
|
|||
| @nox.session(name="test-rust", venv_backend="none") | |||
| def test_rust(session: nox.Session): | |||
| _run_cargo_package_metadata_test(session, packages=["pyo3", "pyo3-ffi"]) | |||
There was a problem hiding this comment.
Will pyo3 and pyo3-ffi always support exactly the same versions? I guess so. Should we ensure their metadata is always in sync? Or should we have it only on pyo3-ffi? 🤔
There was a problem hiding this comment.
Or should we have it only on
pyo3-ffi?
Good point, I think have it only on a leaf dependency makes sense!
Co-authored-by: David Hewitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use workspace inheritance to reduce duplication, but when inspecting the
cargo packageartifact It does not seem to work.Closes #4751